Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove checking for valid images so other file extensions can be used #132

Closed
wants to merge 1 commit into from

Conversation

janekkkk
Copy link

Solves #84

@devTam
Copy link

devTam commented Jun 8, 2022

Can this be merged please? This feature is needed

@Jason-Weyland
Copy link

@janekkkk can we get this merged in? I'm running into issues that this would fix.

@vutoan266
Copy link
Owner

hi @janekkkk, thank you so much for your enthusiasm to make a good PR. It will work well for your case.
But after some consideration, I decide to continue to retain image checking logic, and will support one more prop allowNonImageType in version 3.1.7.
Anyway, the lib was born to solve image business, so I think the new prop will serve your demand and still keep the original purpose itself.
Again, thank you bro!

@vutoan266
Copy link
Owner

Hi @devTam and @Jason-Weyland you guys can try the new version 3.1.7. Feel free to connect with me if have any issues or concerns.

@janekkkk janekkkk closed this Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants