Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset Url optional output on asset loading nodes #686

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sebescudie
Copy link

PR Details

Adds an optional Url output pin to asset loading nodes.

Description

This PR adds an optional Url pin to the following nodes :

  • FileTexture
  • FileTextureGrayscale
  • FileTextureNormalMap
  • FileModel

This pin returns the computed asset Url. The added link is highlighted in the following screenshot :

From the outside, after enabling the Url pin via Configure, the user would see the following :

Related Issue

None

Motivation and Context

Getting the asset Url would allow to query the asset manager to see if this asset has already been loaded, or in use somewhere in the running application.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation

@sebescudie
Copy link
Author

Happy to discuss this one! If it's accepted, I'm happy to update the Load Assets from File help patch in that PR as well to mention the existence of that pin.

@sebescudie sebescudie changed the title Feature/asset url optional output Asset Url optional output on asset loading nodes Dec 2, 2024
@sebescudie sebescudie marked this pull request as ready for review December 4, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant