Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T6718: use the vyconf daemon for validation of set commands #94

Open
wants to merge 4 commits into
base: current
Choose a base branch
from
Open

T6718: use the vyconf daemon for validation of set commands #94

wants to merge 4 commits into from

Conversation

jestabro
Copy link
Contributor

@jestabro jestabro commented Oct 26, 2024 •
edited
Loading

Change Summary

This is a companion PR for
vyos/vyconf#11

It is in draft pending the merge of the above.

It exposes and separates the legacy validate/set function for use by the vyconf vyos1x-adapter.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@jestabro
T5528: add adapter interface
3e16a23 
Expose legacy set/delete functions in a form suitable for external
calls.
@jestabro
T6717: add redirect_stdout
9d47872 
Legacy set/delete methods write errors to stdout; capture for
redirection in return value.
@jestabro
T6717: split validate and set functions
39ec15b 
Separate the application of validators from the cstore update.
@jestabro
T6717: memory management of alloced return values
a428d47 
The ctypes binding makes a copy of the string return value; the
originating C memory allocation needs to be explicitly managed.
@jestabro jestabro self-assigned this Oct 26, 2024
@jestabro jestabro requested a review from a team as a code owner October 26, 2024 04:03
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 26, 2024 •
edited
Loading

👍
No issues in PR Title / Commit Title

@jestabro jestabro mentioned this pull request Oct 26, 2024
Merged
10 tasks
@jestabro jestabro marked this pull request as draft October 26, 2024 04:21
@jestabro jestabro mentioned this pull request Nov 14, 2024
Draft
10 tasks
@jestabro
Copy link
Contributor Author

Force push to split off the last commit into a separate PR:
#95
This will allow a cleaner sequencing of merges of the PRs related to T6718.

@jestabro jestabro marked this pull request as ready for review November 14, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmbaturin dmbaturin Awaiting requested review from dmbaturin

@sarthurdev sarthurdev Awaiting requested review from sarthurdev

@sever-sever sever-sever Awaiting requested review from sever-sever

@c-po c-po Awaiting requested review from c-po

@zdc zdc Awaiting requested review from zdc zdc is a code owner automatically assigned from vyos/reviewers

@nicolas-fort nicolas-fort Awaiting requested review from nicolas-fort nicolas-fort is a code owner automatically assigned from vyos/reviewers

At least 2 approving reviews are required to merge this pull request.

Assignees

@jestabro jestabro

Labels
current
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jestabro