load-config: T5815: provide a variety of load config methods #2608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyosbot
requested review from
a team,
dmbaturin,
sarthurdev,
zdc,
sever-sever and
c-po
and removed request for
a team
12 tasks
jestabro
force-pushed
the
load-config-module
branch
4 times, most recently
from
16b29a0
to
c7198c3
Compare
Collect in a module several versions of a 'load config' function. They have different use cases according to performance and error reporting, and allow comparison of non-legacy and legacy variants.
jestabro
force-pushed
the
load-config-module
branch
from
c7198c3
to
7e4caa1
Compare
sever-sever
approved these changes
Dec 11, 2023
dmbaturin
approved these changes
Dec 11, 2023
|
@Mergifyio backport sagitta |
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collect in a module several versions of a 'load config' function. They have different use cases according to performance and error reporting, and allow comparison of non-legacy and legacy variants.
Define several version of a load_config function as an alternative to the legacy load config script, for use, notably, in
(1) 'soft-rollback', as discussed with @sever-sever
https://vyos.dev/T5249
#2596
(2) better error reporting for configtest
This also allows easy comparison when adding the legacy batch set/delete patch:
vyos/vyatta-cfg@current...jestabro:cli_batch
mostly for curiosity, as performance is still limited by io string conversions, respectively,
https://vyos.dev/T5528
which will resolve those limits.
Change Summary
Types of changes
Related Task(s)
Related PR(s)
Component(s) name
Proposed changes
How to test
Smoketest result
Checklist: