Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system_login: T6807: allow a trailing slash character in system login #4171

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

aslanvyos
Copy link
Contributor

Allow the use of a trailing slash ("/") at the of the user's home directory path. For example /home/test/

Change Summary

After the migration VyOS version from 1.3.x to 1.4.0, the presence of a trailing slash ("/") at the end of the user's home directory path beaks the login process.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

After migrating from VyOS version 1.3.x to 1.4.0, the presence of a trailing slash ("/") at the end of the user's home directory path breaks the login process. This issue affects both login/password authentication and SSH key-based access, making it impossible for users to log in to VyOS instances.
To resolve this issue, I propose allowing the use of a trailing slash ("/") in the home directory path. This change will ensure that users do not encounter login problems after future migrations.

Examples of Allowed Paths:

  • With Trailing Slash: /home/test/
  • Without Trailing Slash: /home/test

Examples of Disallowed Paths:

  • //home/test/ (contains double slashes)
  • /home//test (contains double slashes)
  • home/test/ (does not start with a slash)

How to test

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Allow the use of a trailing slash `("/")` at the of the user's home directory path. For example `/home/test/`
Copy link

👍
No issues in PR Title / Commit Title

Copy link

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests (no interfaces) ❌ failed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

@dmbaturin dmbaturin merged commit 47aa697 into vyos:current Nov 1, 2024
15 of 16 checks passed
@dmbaturin
Copy link
Member

CI failures are unrelated to the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants