Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dhcp_server: T6031: DHCP Option Failures - windows-static-route #4183

Open
wants to merge 1 commit into
base: current
Choose a base branch
from

Conversation

natali-rs1985
Copy link
Contributor

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

service dhcp-server

Proposed changes

Added new TuneD profiles and ability to activate several profiles

How to test

set interfaces ethernet eth1 address '192.168.100.1/24'

set service dhcp-server shared-network-name LAN subnet 192.168.100.0/24 lease '86400'
set service dhcp-server shared-network-name LAN subnet 192.168.100.0/24 option default-router '192.168.100.1'
set service dhcp-server shared-network-name LAN subnet 192.168.100.0/24 option domain-name 'vyos.net'
set service dhcp-server shared-network-name LAN subnet 192.168.100.0/24 option name-server '192.168.100.1'
set service dhcp-server shared-network-name LAN subnet 192.168.100.0/24 option static-route 192.168.0.0/16 next-hop '192.168.100.1'
set service dhcp-server shared-network-name LAN subnet 192.168.100.0/24 range 0 start '192.168.100.9'
set service dhcp-server shared-network-name LAN subnet 192.168.100.0/24 range 0 stop '192.168.100.254'
set service dhcp-server shared-network-name LAN subnet 192.168.100.0/24 subnet-id '1'
commit
vyos@vyos# systemctl status kea-dhcp4-server.service
● kea-dhcp4-server.service - Kea IPv4 DHCP daemon
     Loaded: loaded (/lib/systemd/system/kea-dhcp4-server.service; disabled; preset: enabled)
    Drop-In: /etc/systemd/system/kea-dhcp4-server.service.d
             └─override.conf
     Active: active (running) since Wed 2024-10-30 16:53:51 UTC; 3min 19s ago
       Docs: man:kea-dhcp4(8)
   Main PID: 92937 (kea-dhcp4)
      Tasks: 6 (limit: 1129)
     Memory: 2.9M
        CPU: 68ms
     CGroup: /system.slice/kea-dhcp4-server.service
             └─92937 /usr/sbin/kea-dhcp4 -c /run/kea/kea-dhcp4.conf

Smoketest result

vyos@vyos# python3 /usr/libexec/vyos/tests/smoke/cli/test_service_dhcp-server.py
test_dhcp_exclude_in_range (__main__.TestServiceDHCPServer.test_dhcp_exclude_in_range) ... ok
test_dhcp_exclude_not_in_range (__main__.TestServiceDHCPServer.test_dhcp_exclude_not_in_range) ... ok
test_dhcp_high_availability (__main__.TestServiceDHCPServer.test_dhcp_high_availability) ... ok
test_dhcp_high_availability_standby (__main__.TestServiceDHCPServer.test_dhcp_high_availability_standby) ... ok
test_dhcp_multiple_pools (__main__.TestServiceDHCPServer.test_dhcp_multiple_pools) ... ok
test_dhcp_on_interface_with_vrf (__main__.TestServiceDHCPServer.test_dhcp_on_interface_with_vrf) ... ok
test_dhcp_relay_server (__main__.TestServiceDHCPServer.test_dhcp_relay_server) ... ok
test_dhcp_single_pool_options (__main__.TestServiceDHCPServer.test_dhcp_single_pool_options) ... ok
test_dhcp_single_pool_options_scoped (__main__.TestServiceDHCPServer.test_dhcp_single_pool_options_scoped) ... ok
test_dhcp_single_pool_range (__main__.TestServiceDHCPServer.test_dhcp_single_pool_range) ... ok
test_dhcp_single_pool_static_mapping (__main__.TestServiceDHCPServer.test_dhcp_single_pool_static_mapping) ... ok

----------------------------------------------------------------------
Ran 11 tests in 76.251s

OK

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

In "option-def" parameter "record-types" field is an array of uint8 in format "<netmask>, <network-byte1>, <network-byte2>, <network-byte3>, <router-byte1>, <router-byte2>, <router-byte3>" where <network-byte3> with the value 0 is omitted, so the minimal length of array is 7 (e.g. for routing 10.1.0.0/16 via 10.1.6.4 "record-types": "16,10,1,10,1,6,4")
Copy link

github-actions bot commented Nov 5, 2024

👍
No issues in PR Title / Commit Title

Copy link

github-actions bot commented Nov 5, 2024

CI integration 👍 passed!

Details

CI logs

  • CLI Smoketests (no interfaces) 👍 passed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant