Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conntrack: T6878: stop the conntrack logger daemon correctly #4193

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

HollyGurza
Copy link
Contributor

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

vyos@vyos# set system conntrack log event new 
[edit]
vyos@vyos# commit
[edit]
vyos@vyos# ps aux | grep vyos-conntrack-logger
root        6866  3.1  3.6 119108 36324 ?        Ssl  02:57   0:00 /usr/bin/python3 -u /usr/libexec/vyos/services/vyos-conntrack-logger -c /run/vyos-conntrack-logger.conf
root        6897  0.1  2.9 119108 29292 ?        S    02:57   0:00 /usr/bin/python3 -u /usr/libexec/vyos/services/vyos-conntrack-logger -c /run/vyos-conntrack-logger.conf
vyos        6914  0.0  0.2   6468  2176 pts/2    S+   02:57   0:00 grep vyos-conntrack-logger
[edit]
vyos@vyos# del system conntrack log 
[edit]
vyos@vyos# commit
[edit]
vyos@vyos# ps aux | grep vyos-conntrack-logger
vyos        6982  0.0  0.2   6468  2048 pts/2    S+   02:57   0:00 grep vyos-conntrack-logger
[edit]
vyos@vyos# 

Smoketest result

vyos@vyos:~$ python3 /usr/libexec/vyos/tests/smoke/cli/test_system_conntrack.py 
test_conntrack_hash_size (__main__.TestSystemConntrack.test_conntrack_hash_size) ... ok
test_conntrack_ignore (__main__.TestSystemConntrack.test_conntrack_ignore) ... ok
test_conntrack_log (__main__.TestSystemConntrack.test_conntrack_log) ... ok
test_conntrack_module_enable (__main__.TestSystemConntrack.test_conntrack_module_enable) ... ok
test_conntrack_options (__main__.TestSystemConntrack.test_conntrack_options) ... ok
test_conntrack_timeout_custom (__main__.TestSystemConntrack.test_conntrack_timeout_custom) ... ok

----------------------------------------------------------------------
Ran 6 tests in 41.183s

OK

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Nov 15, 2024

👍
No issues in PR Title / Commit Title

Copy link

CI integration 👍 passed!

Details

CI logs

  • CLI Smoketests (no interfaces) 👍 passed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

@dmbaturin dmbaturin changed the title T6878: Stop conntrack logging service conntrack: T6878: stop the conntrack logger daemon correctly Nov 15, 2024
@dmbaturin dmbaturin merged commit 4842a70 into vyos:current Nov 15, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants