Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T6013: Add support for AuthorizedPrincipalsFile to trusted_user_ca_key #4266

Draft
wants to merge 6 commits into
base: current
Choose a base branch
from
Draft

T6013: Add support for AuthorizedPrincipalsFile to trusted_user_ca_key #4266

wants to merge 6 commits into from
+196 −18

Conversation

takehaya
Copy link
Contributor

@takehaya takehaya commented Dec 28, 2024 •
edited
Loading

Change Summary

This PR complements vyos/vyos-1x#4234 by adding support for AuthorizedPrincipalsFile. With this enhancement, SSH login using CA certificates and arbitrary user principals is now fully supported.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

#4234

Component(s) name

Proposed changes

How to test

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@takehaya
T6013: Add support for AuthorizedPrincipalsFile to trusted_user_ca_key
df6d110 
This commit introduces the bind-user subcommand to support
AuthorizedPrincipalsFile. With this addition, it is now possible to
associate SSH login users with their respective principals.
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 28, 2024 •
edited
Loading

👍
No issues in PR Title / Commit Title

@takehaya takehaya force-pushed the T6013-trusted-ca-keys branch from cf3ce1d to 0ae9aad Compare December 28, 2024 20:31
@takehaya takehaya force-pushed the T6013-trusted-ca-keys branch from 0d74b4e to 387d4ba Compare December 28, 2024 21:15
@github-actions GitHub Actions
Copy link

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests (no interfaces) ❌ failed
  • CLI Smoketests (interfaces only) ❌ failed
  • Config tests ❌ failed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmbaturin dmbaturin Awaiting requested review from dmbaturin dmbaturin will be requested when the pull request is marked ready for review dmbaturin is a code owner

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev will be requested when the pull request is marked ready for review sarthurdev is a code owner

@jestabro jestabro Awaiting requested review from jestabro jestabro will be requested when the pull request is marked ready for review jestabro is a code owner

@sever-sever sever-sever Awaiting requested review from sever-sever sever-sever will be requested when the pull request is marked ready for review sever-sever is a code owner

@c-po c-po Awaiting requested review from c-po c-po will be requested when the pull request is marked ready for review c-po is a code owner

@fett0 fett0 Awaiting requested review from fett0 fett0 will be requested when the pull request is marked ready for review fett0 is a code owner

@nicolas-fort nicolas-fort Awaiting requested review from nicolas-fort nicolas-fort will be requested when the pull request is marked ready for review nicolas-fort is a code owner

@zdc zdc Awaiting requested review from zdc zdc will be requested when the pull request is marked ready for review zdc is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@takehaya takehaya

Labels
current
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@takehaya