T7897: VPP: fix rx-mode interrupt for XDP driver with workers

[natali-rs1985]

Remove no-syscall-lock from CLI and enable this option if workers are configured.
Also forbid interrupt mode for ixgbevf driver

Change summary

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Code style update (formatting, renaming)
• Refactoring (no functional changes)
• Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
• Other (please describe):

Related Task(s)

• https://vyos.dev/T7897

Related PR(s)

vyos/vyos-documentation#1691

How to test / Smoketest result

set vpp settings cpu main-core '1'
set vpp settings interface eth1 driver 'xdp'
set vpp settings interface eth1 rx-mode 'interrupt'

set vpp settings cpu workers '1'

vyos@vyos# commit
[edit]
vyos@vyos# sudo vppctl show hardware-interfaces
              Name                Idx   Link  Hardware
eth1                               1     up   eth1
  Link speed: unknown
  RX Queues:
    queue thread         mode
    0     main (0)       interrupt
  TX Queues:
    TX Hash: [name: hash-eth-l34 priority: 50 description: Hash ethernet L34 headers]
    queue shared thread(s)
    0     no     0
  Ethernet address 0c:f2:f4:cc:00:01
  netdev defunct_eth1
  flags: admin-up
...

Checklist:

• I have read the CONTRIBUTING document
• I have linked this PR to one or more Phabricator Task(s)
• I have run the components SMOKETESTS if applicable
• My commit headlines contain a valid Task id
• My change requires a change to the documentation
• I have updated the documentation accordingly

[github-actions]

👍
No issues in PR Title / Commit Title

[dmbaturin]

Sorry, mis-click.

[dmbaturin]

I'm a bit confused by this PR. It has four distinct parts:

1. A fix for a typo in the flag name, s/no_systcall_lock/no_syscall_log/ — no objections here.
2. A fix for the internal flag name for xdp-options, s/no-syscall-lock/zero-copy/ — probably also fine.
3. A complete removal of ixgbevf from the list of drivers that support the interrupt mode — probably fine, if it doesn't.
4. A removal of the no-syscall-lock option from the CLI.

I don't understand the point #4 — if there's no option anymore, where would the no_syscall_lock flag be coming from? Also, a while ago we agreed that VPP is no longer experimental and config syntax changes now require migration scripts, if they are necessary.

[natali-rs1985]

I don't understand the point #4 — if there's no option anymore, where would the no_syscall_lock flag be coming from? Also, a while ago we agreed that VPP is no longer experimental and config syntax changes now require migration scripts, if they are necessary.

We decided to remove this option from the CLI because it must be used with interrupt/adaptive mode with vpp workers (if it doesn't vpp fails to start). If this conditions are met we set this flag automatically. In other cases it is not needed

I'll add a migration script for this option

[sever-sever]

Remove no-syscall-lock for config
Use this flag internally

[zdc]

The code looks logical to me. I have not tested it.

[github-actions]

CI integration ❌ failed!

Details

CI logs

• CLI Smoketests (no interfaces) 👍 passed
• CLI Smoketests VPP 👍 passed
• CLI Smoketests (interfaces only) ❌ failed
• Config tests 👍 passed
• Config tests VPP 👍 passed
• RAID1 tests 👍 passed
• TPM tests 👍 passed