Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update with Network Resources templates #358

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

gaige
Copy link
Contributor

@gaige gaige commented Nov 15, 2024

Change Summary

Minor modifications by bringing the resource_module_builder-based modules back into line with what is generated, fixing some variances in documentation and inconsistencies in some of the modules and the documentation and
test sources.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Other (please describe):

Related Task(s)

Related PR(s)

Proposed changes

Updates to the resource module repo (separate) to bring them into line with the current code.
Added a custom version of the resource_builder in order to ensure we don't remove any
updates for our modules.
Regenerated until we matched all salient updates.

How to test

ansible-test units --docker
ansible-test sanity
ansible-test network-integration --inventory `pwd`/inventory.network

Unit tests and sanity tests pass; integration tests are failing in the same ways that the current mainline branch are
failing against 1.4 and 1.5 (but work against 1.3).

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant