ci: Use pull_request_target with permissions check
#142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.github/workflows/main.yaml
Outdated
| @@ -1,24 +1,21 @@ | |||
| name: unitary | |||
|
|
|||
| on: ["push", "pull_request"] | |||
There was a problem hiding this comment.
not sure we want to disable test on push
There was a problem hiding this comment.
i also don't think pull_request_target tests the merge commit, which may be a problem. maybe we should run all three?
There was a problem hiding this comment.
I've added push to master and pull_request, but then without the integration tests
DanielSchiavini
changed the title
pull_request_target with permissions checkpull_request_target with permissions check
charles-cooper
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
looks like it's working - https://github.com/DanielSchiavini/titanoboa/actions/runs/7903435212/job/21571324351?pr=3
since we jerry-rigged `pull_request_target` to run against the merge commit
charles-cooper
changed the title
pull_request_target with permissions checkpull_request_target with permissions check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Changed the pipeline to use the
pull_request_target, so users with push access may run the pipeline using secrets.How I did it
By using a small github script that calls getCollaboratorPermissionLevel
How to verify it
Make a PR targetting this branch (pipeline) in my fork. The integration pipeline should raise an error.
Here is an example of a successful check targeting this branch.
Description for the changelog
N/A
Cute Animal Picture