Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: storage read and refund strategy #161

Merged
merged 8 commits into from
Feb 15, 2024
Merged

Fix: storage read and refund strategy #161

merged 8 commits into from
Feb 15, 2024

Conversation

romanagureev
Copy link
Contributor

What I did

  • Storage does not show deleted slots as though they are not registered. Thence data is fetched from RPC and leads to errors.
  • According to EIP2200 specification call-frame refund counters can go negative, so I changed strategy to appropriate.

How I did it

  • Added more precise checks along with autocaching values.
  • Set strategy at initialisation.

How to verify it

There is a test flipping slot to zero and back.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@charles-cooper charles-cooper merged commit 9d3c24e into vyperlang:master Feb 15, 2024
6 of 8 checks passed
@charles-cooper
Copy link
Member

thanks @romanagureev, very nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romanagureev @charles-cooper