feat: add deploy_as_blueprint to VVMDeployer
#311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
197
to
199
| bytecode=generate_blueprint_bytecode( | ||
| compiler_data.bytecode, blueprint_preamble | ||
| ), |
There was a problem hiding this comment.
do we really need this much nesting?
boa/contracts/vvm/vvm_contract.py
Outdated
| if env is None: | ||
| env = Env.get_singleton() | ||
| bytecode = generate_blueprint_bytecode(self.bytecode) | ||
| address, _ = env.deploy_code(bytecode=bytecode) |
There was a problem hiding this comment.
need to register the blueprint
boa/contracts/vvm/vvm_contract.py
Outdated
| """ | ||
| if env is None: | ||
| env = Env.get_singleton() | ||
| bytecode = generate_blueprint_bytecode(self.bytecode) |
charles-cooper
approved these changes
Oct 2, 2024
charles-cooper
changed the title
deploy_as_blueprint to VVMDeployer
DanielSchiavini
commented
Oct 3, 2024
| # TODO: add filename | ||
| return ABIContractFactory.from_abi_dict([]) | ||
|
|
||
| def deploy_as_blueprint(self, env=None, blueprint_preamble=None, **kwargs): |
There was a problem hiding this comment.
blueprint_preamble=None, **kwargs are unused now
Leminkay
pushed a commit
to Leminkay/titanoboa
that referenced
this pull request
Oct 28, 2024
--------- Co-authored-by: Charles Cooper <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
Description for the changelog
Cute Animal Picture