feat: added warning suppression for if you don't care that a contract has no bytecode #313
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I added a
suppress_warning: bool = False
keyword argument to:ABIContract::__init__
ABIContract::at
The rationale for this is as such:
from_etherscan
command inboa
without being on the same network as theuri
will cause this warning to be thrown. So, we should have an option to suppress the warning if we choose a custom uri.CREATE2
to deploy a contractIt may make sense to set this flag to
true
when calling this function fromfrom_etherscan
How I did it
How to verify it
I added the following test:
The code:
Will error if any warning is thrown, so this test passing means the warning is not being thrown.
Description for the changelog
ABIContract
objects created before bytecode assigned to ignore warnings flaggedCute Animal Picture