Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support Python 3.10 #2549

Merged
merged 10 commits into from
Feb 2, 2022
Merged

chore: support Python 3.10 #2549

merged 10 commits into from
Feb 2, 2022

Conversation

fubuloubu
Copy link
Member

What I did

fixes: #2548

How I did it

github ui

How to verify it

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2021

Codecov Report

Merging #2549 (5533cbb) into master (3a9a342) will increase coverage by 0.94%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2549      +/-   ##
==========================================
+ Coverage   86.61%   87.56%   +0.94%     
==========================================
  Files          91       92       +1     
  Lines        9413    10196     +783     
  Branches     2354     2816     +462     
==========================================
+ Hits         8153     8928     +775     
+ Misses        775      770       -5     
- Partials      485      498      +13     
Impacted Files Coverage Δ
vyper/codegen/types/types.py 84.32% <0.00%> (-0.61%) ⬇️
vyper/compiler/phases.py 93.50% <0.00%> (-0.56%) ⬇️
vyper/codegen/types/convert.py 61.29% <0.00%> (ø)
vyper/codegen/abi_encoder.py 85.85% <0.00%> (+0.14%) ⬆️
vyper/builtin_functions/functions.py 88.60% <0.00%> (+0.33%) ⬆️
vyper/compiler/output.py 97.00% <0.00%> (+0.94%) ⬆️
vyper/semantics/validation/local.py 94.22% <0.00%> (+1.99%) ⬆️
vyper/ast/signatures/function_signature.py 90.28% <0.00%> (+2.58%) ⬆️
vyper/lll/s_expressions.py 94.11% <0.00%> (+2.94%) ⬆️
vyper/cli/vyper_json.py 89.01% <0.00%> (+3.75%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a9a342...5533cbb. Read the comment docs.

yaml parses current as the float `3.1`
@istankovic
Copy link

@fubuloubu any news on this?

@fubuloubu
Copy link
Member Author

fubuloubu commented Dec 13, 2021

blake2b-py does not have release binaries yet for Python 3.10

Also... need to set up eth-tester to not use blake2b-py... Which should be possible now.

@charles-cooper
Copy link
Member

The blake2b-py dependency was fixed in ethereum/py-evm#2012 but we can't upgrade py-evm yet because of a dependency conflict in web3.py. Tracking in ethereum/web3.py#2295

@charles-cooper charles-cooper self-requested a review February 2, 2022 19:40
Copy link
Member

@charles-cooper charles-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved pending tests passing

@fubuloubu fubuloubu enabled auto-merge (squash) February 2, 2022 19:46
@fubuloubu fubuloubu merged commit 4dea0cf into master Feb 2, 2022
@fubuloubu fubuloubu deleted the chore/py3.10-support branch February 2, 2022 20:31
tserg pushed a commit to tserg/vyper that referenced this pull request Feb 8, 2022
* Update setup.py

* Update setup.py

* add 3.10 workflow

* Update tox.ini

* fix yaml parsing of "3.10"

yaml parses current as the float `3.1`

* try to fix blake2b-py dep

* update web3.py

* remove blake2b-py again

* add upper bound to py-evm

Co-authored-by: Charles Cooper <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Python 3.10
4 participants