refactor[venom]: use InstUpdater in more passes
#4508
+147
−140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charles-cooper
changed the title
InstUpdater everywhereInstUpdater in more passes
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4508 +/- ##
==========================================
- Coverage 92.16% 92.15% -0.02%
==========================================
Files 122 122
Lines 17471 17467 -4
Branches 2959 2957 -2
==========================================
- Hits 16103 16097 -6
- Misses 957 958 +1
- Partials 411 412 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
charles-cooper
requested review from
harkal and
HodanPlodky
and removed request for
harkal
HodanPlodky
reviewed
Mar 12, 2025
| @@ -14,6 +14,7 @@ class RemoveUnusedVariablesPass(IRPass): | |||
|
|
|||
| def run_pass(self): | |||
| self.dfg = self.analyses_cache.request_analysis(DFGAnalysis) | |||
| self.updater = InstUpdater | |||
There was a problem hiding this comment.
Should not this consume the dfg/call constructor?
There was a problem hiding this comment.
hm, looks like it's not actually used
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -1,7 +1,7 @@ | |||
| from vyper.utils import OrderedSet, uniq | |||
| from vyper.venom.analysis import DFGAnalysis, LivenessAnalysis | |||
| from vyper.venom.basicblock import IRInstruction | |||
| from vyper.venom.passes.base_pass import IRPass | |||
| from vyper.venom.passes.base_pass import InstUpdater, IRPass | |||
Check notice
Code scanning / CodeQL
Unused import Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
it's safer and faster for passes which modify the dfg to modify it in place using InstUpdater
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture