Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor[venom]: update more passes to use InstUpdater #4516

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Mar 12, 2025

What I did

update more passes to use InstUpdater.

  • found a latent bug in MakeSSA (it was not invalidating the dfg, which was only tripped after updating LowerDLoadPass to not invalidate the dfg).
  • fixed a latent bug in InstUpdater.update() - it did not delete the op from dfg_outputs after update

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 6 lines in your changes missing coverage. Please review.

Project coverage is 92.16%. Comparing base (41108f9) to head (3eacd7e).

Files with missing lines Patch % Lines
vyper/venom/passes/machinery/inst_updater.py 79.16% 3 Missing and 2 partials ⚠️
vyper/venom/passes/mem2var.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4516   +/-   ##
=======================================
  Coverage   92.15%   92.16%           
=======================================
  Files         123      123           
  Lines       17469    17478    +9     
  Branches     2957     2963    +6     
=======================================
+ Hits        16099    16108    +9     
+ Misses        958      957    -1     
- Partials      412      413    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@charles-cooper charles-cooper marked this pull request as ready for review March 12, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant