queries: fix partially-uninitialized struct #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `x` instance wasn't initialized properly, which led to undefined behaviour in _tgl_do_send_photo when copying its content to t->avatar. This patch fixes that by using the C struct initializer syntax, which implicitly sets all missing fields to 0. Note that this UB triggers a compilation warning when compiling with recent GCC versions in -O3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
xinstance wasn't initialized properly, which led to undefinedbehaviour in _tgl_do_send_photo when copying its content to t->avatar.
This patch fixes that by using the C struct initializer syntax, which
implicitly sets all missing fields to 0.
Note that this UB triggers a compilation warning when compiling with
recent GCC versions in -O3.