Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix libgcrypt init, _free_photo, and the duplicate ID thing #94

Closed
wants to merge 6 commits into from
Closed

Fix libgcrypt init, _free_photo, and the duplicate ID thing #94

wants to merge 6 commits into from

Conversation

BenWiederhake
Copy link
Contributor

Otherwise, this spews an ugly warning, e.g. in Finch:
Libgcrypt warning: missing initialization - please fix the application

Sorry that I didn't implement proper initialization from the start, I thought I could get away without it :P

@BenWiederhake BenWiederhake mentioned this pull request Feb 18, 2016
Closed
@majn
Copy link
Contributor

majn commented Feb 18, 2016

You are fast 👍

@BenWiederhake
Copy link
Contributor Author

Only when I'm actually working on something :P
Don't forget that I didn't move a finger during the last 4-5 weeks.

@BenWiederhake BenWiederhake changed the title Properly initialize libgcrypt on start Fix libgcrypt init and _free_photo Feb 18, 2016
@BenWiederhake BenWiederhake deleted the fix-gcrypt-init branch February 27, 2016 14:26
@BenWiederhake BenWiederhake reopened this Feb 27, 2016
@BenWiederhake
Copy link
Contributor Author

Sorry for the wrong push.
Added the fix to #85. (That bug is known in tgp as majn/telegram-purple#220 (comment) )

@BenWiederhake BenWiederhake changed the title Fix libgcrypt init and _free_photo Fix libgcrypt init, _free_photo, and the duplicate ID thing Feb 27, 2016
@BenWiederhake
Copy link
Contributor Author

@vysheng: Is there anything preventing this from being pushed? Can I help somehow?

@BenWiederhake BenWiederhake mentioned this pull request Mar 14, 2016
Closed
@BenWiederhake BenWiederhake mentioned this pull request Mar 31, 2016
Open
@BenWiederhake
Copy link
Contributor Author

@vysheng: Is there anything preventing this from being pushed? Can I help somehow?

Please merge this, it fixes two crashing bugs and a security warning thing.

@BenWiederhake
Copy link
Contributor Author

@vysheng: Is there anything preventing this from being pushed? Can I help somehow?

Please merge this, it fixes two crashing bugs and a security thing.

@BenWiederhake BenWiederhake mentioned this pull request Jun 23, 2016
Closed
@BenWiederhake
Copy link
Contributor Author

Pushed two more commits that fix user-visible bugs.

@vysheng: Is there anything preventing this from being pushed? Can I help somehow? Does this need rebasing?

Please merge this, by now it fixes at least four crashing bugs and a security thing.

@BenWiederhake BenWiederhake mentioned this pull request Jul 18, 2016
Merged
@BenWiederhake
Copy link
Contributor Author

Fixed the OpenSSL-version of the TGLC_init function, introduced in the first of the commits.

@vysheng: Is there anything preventing this from being pushed? Can I help somehow? Does this need rebasing?

Please merge this, by now it fixes at least four crashing bugs and a security thing.

BenWiederhake and others added 6 commits August 2, 2016 00:34
@BenWiederhake
Properly initialize libgcrypt on start
7379b2e
@BenWiederhake
Fix use-after-not-created for photos
5eaafed 
Fix reported by @spaeps in majn/telegram-purple#238
Closes vysheng#42
I didn't actually do anything, except forward this patch.
@BenWiederhake
Use a single, global counter
c58612b
@BenWiederhake
Adapt mime-types.c auto-gen to vysheng's behavior
50976e9 
The referenced target "gen-mime-types" was wrong anyway.
@avsej @BenWiederhake
Fix build on solaris (-Werror=return-type)
d62f8b5 
./auto-static-autocomplete.c:72:1: error: control reaches end of
non-void function [-Werror=return-type]
@BenWiederhake
Free messages exactly once
254999c
@BenWiederhake
Copy link
Contributor Author

Swallowed by #97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenWiederhake @majn @avsej