issue fixed where short keys were not working at start

fixes #25
w-ahmad · Jun 24, 2024 · 62f657a · 62f657a
1 parent babc1ae
commit 62f657a
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 18 deletions.
diff --git a/src/WinUI.TableView/TableView.cs b/src/WinUI.TableView/TableView.cs
@@ -94,6 +94,12 @@ protected override void OnPreviewKeyDown(KeyRoutedEventArgs e)
         var ctrlKey = KeyBoardHelper.IsCtrlKeyDown();
         var currentCell = CurrentCellSlot.HasValue ? GetCellFromSlot(CurrentCellSlot.Value) : default;
 
+        if (HandleShortKeys(shiftKey, ctrlKey, e.Key))
+        {
+            e.Handled = true;
+            return;
+        }
+
         if (e.Key is VirtualKey.F2 && currentCell is not null && !IsEditing)
         {
             currentCell.PrepareForEdit();
@@ -155,6 +161,27 @@ protected override void OnPreviewKeyDown(KeyRoutedEventArgs e)
         }
     }
 
+    private bool HandleShortKeys(bool shiftKey, bool ctrlKey, VirtualKey key)
+    {
+        if (key == VirtualKey.A && ctrlKey && !shiftKey)
+        {
+            SelectAll();
+            return true;
+        }
+        else if (key == VirtualKey.A && ctrlKey && shiftKey)
+        {
+            DeselectAll();
+            return true;
+        }
+        else if (key == VirtualKey.C && ctrlKey)
+        {
+            CopyToClipboardInternal(shiftKey);
+            return true;
+        }
+
+        return false;
+    }
+
     protected override void OnApplyTemplate()
     {
         base.OnApplyTemplate();

diff --git a/src/WinUI.TableView/TableViewHeaderRow.cs b/src/WinUI.TableView/TableViewHeaderRow.cs
@@ -50,18 +50,6 @@ protected override void OnApplyTemplate()
         if (_optionsButton is not null)
         {
             _optionsButton.DataContext = new OptionsFlyoutViewModel(TableView);
-
-            // Hack: this will allow keyboard accelerators to get work
-            ShowAndHidOptionsFlyout();
-            async void ShowAndHidOptionsFlyout()
-            {
-                if (_optionsButton.Visibility == Visibility.Visible)
-                {
-                    _optionsButton.Flyout.ShowAt(_optionsButton);
-                    await Task.Delay(5);
-                    _optionsButton.Flyout.Hide();
-                }
-            }
         }
 
         if (GetTemplateChild("selectAllButton") is Button selectAllButton)

diff --git a/src/WinUI.TableView/Themes/TableViewHeaderRow.xaml b/src/WinUI.TableView/Themes/TableViewHeaderRow.xaml
@@ -107,8 +107,7 @@
                                                         Icon="ClearSelection">
                                             <MenuFlyoutItem.KeyboardAccelerators>
                                                 <KeyboardAccelerator Key="A"
-                                                                     Modifiers="Control,Shift"
-                                                                     ScopeOwner="{TemplateBinding TableView}" />
+                                                                     Modifiers="Control,Shift" />
                                             </MenuFlyoutItem.KeyboardAccelerators>
                                         </MenuFlyoutItem>
                                         <MenuFlyoutSeparator />
@@ -120,12 +119,10 @@
                                                                      ScopeOwner="{TemplateBinding TableView}" />
                                             </MenuFlyoutItem.KeyboardAccelerators>
                                         </MenuFlyoutItem>
-                                        <MenuFlyoutItem Command="{Binding CopyWithHeadersCommand}"
-                                                        KeyboardAcceleratorPlacementTarget="{TemplateBinding TableView}">
+                                        <MenuFlyoutItem Command="{Binding CopyWithHeadersCommand}">
                                             <MenuFlyoutItem.KeyboardAccelerators>
                                                 <KeyboardAccelerator Key="C"
-                                                                     Modifiers="Control,Shift"
-                                                                     ScopeOwner="{TemplateBinding TableView}" />
+                                                                     Modifiers="Control,Shift" />
                                             </MenuFlyoutItem.KeyboardAccelerators>
                                         </MenuFlyoutItem>
                                         <MenuFlyoutSeparator />