Feat/ams form additions #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhofvendahl
requested review from
OR13,
mprorock,
mkhraisha and
nissimsan
as code owners
OR13
reviewed
May 19, 2023
OR13
reviewed
May 19, 2023
OR13
reviewed
May 19, 2023
OR13
reviewed
May 19, 2023
OR13
reviewed
May 19, 2023
OR13
requested changes
May 19, 2023
mkhraisha
approved these changes
May 30, 2023
|
I'm closing this for now, to be re-opened when I've finished the refactor suggested on last week's call. |
|
I've refactored ExtendedProduct into AgProduct and Product, which should be a lot cleaner. |
nissimsan
approved these changes
Oct 3, 2023
| @@ -0,0 +1,81 @@ | |||
| $linkedData: | |||
| term: ExtendedProduct | |||
There was a problem hiding this comment.
This seems like a slighty off pattern here?
There was a problem hiding this comment.
I suggest adding this to AgricultureProduct instead
OR13
reviewed
Oct 3, 2023
| @@ -76,7 +69,51 @@ properties: | |||
| type: string | |||
| $linkedData: | |||
| term: labelImageHash | |||
| '@id': https://schema.org/sha256 | |||
| '@id': https://w3id.org/traceability#labelImageHash | |||
There was a problem hiding this comment.
too bad we don't have a better term def for this
OR13
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add additional fields & schemas to improve
USDASpecialtyCrops237AForm, in response to stakeholder feedback.