Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add term and @id for serviceEndpoint #923

Conversation

PatStLouis
Copy link
Contributor

Addresses this issue.

Let me know if this reflects what we discussed.

Additionally, do we want to also include the following endpoints in the description?

      - https://platform.example/organization/123/credentials/status
      - https://platform.example/organization/123/presentations

I can bundle this into this pr.

@nissimsan @mkhraisha

@brownoxford
Copy link
Collaborator

Does this fix the issue you are seeing when you test locally with the new traceability-v1.jsonld? I notice that the document still contains the empty context for TraceabilityAPI:

       "TraceabilityAPI": {
           "@id": "https://w3id.org/traceability#TraceabilityAPI",
           "@context": {}
       },

and also that serviceEndpoint is already defined in https://www.w3.org/ns/did/v1.

@PatStLouis
Copy link
Contributor Author

@brownoxford @mkhraisha please be aware of this pr on the pyld repository and feel free to chime in, we found a bug in the library which was evaluating empty contexts as null values, as is indicated by section 5.1 of the json-ld expansion algorithm. An additional review would be welcome!

@mkhraisha
Copy link
Collaborator

Closed as resolved in a different library

@mkhraisha mkhraisha closed this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants