Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC Gov Mines Act Permit Credential #929

Conversation

PatStLouis
Copy link
Contributor

This is a draft PR looking to align the BC Gov Energy and Mines Digital Trust framework with the traceability vocab to enable data exchanges. We are looking for feedback from both the traceability group on where these credentials would fit and the BC Gov EMDT governance team.

Here's the reference documentation

permit_no:
title: Permit Number
description: >-
(3-digit) Alpha-numeric identifier: M-##- or C-##- Permit Numbers are assigned to a specific mining operation or activity that has been granted permission or authorization. Mines Act Section 10 (1).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3-digit, so shouldn't there be 3 numeric placeholders?

Suggested change
(3-digit) Alpha-numeric identifier: M-##- or C-##- Permit Numbers are assigned to a specific mining operation or activity that has been granted permission or authorization. Mines Act Section 10 (1).
(3-digit) Alpha-numeric identifier: M-###- or C-###- Permit Numbers are assigned to a specific mining operation or activity that has been granted permission or authorization. Mines Act Section 10 (1).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will request an example to find out and confirm the exact form of the value.

- tsf_operating_count
- tsf_care_and_maintenance_count
example: |-
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fill these up with sample values

type: object
additionalProperties: false
example: |-
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to previous comment about examples

type: string
enum:
- MinesActPermit
permit_no:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you switch from snake to camel casing, pls, for consistency with all other schemas.

@mkhraisha
Copy link
Collaborator

has there been any movement on this PR?

@nissimsan
Copy link
Collaborator

@PatStLouis , any updates on this?

@PatStLouis
Copy link
Contributor Author

@nissimsan we are closing this PR as our efforts with the MinesActPermit will be focused on UNTP

@PatStLouis PatStLouis closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants