Move sizeOrAmount to AgProduct #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhofvendahl
requested review from
OR13,
mprorock,
mkhraisha and
nissimsan
as code owners
rhofvendahl
changed the title
OR13
approved these changes
Mar 12, 2024
mkhraisha
approved these changes
Mar 12, 2024
|
Lets make sure not to close the issue until the Volume PR is merged as well. |
nissimsan
approved these changes
Mar 12, 2024
|
@rhofvendahl , please address merge conflict and merge out of band. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This problem addresses the concern raised in #564 about the
sizeOrAmountproperty on Product. As this is used in ag schemas to indicate unit quantity, I've made a similarunitQuantityproperty onAgProductto take its place for ag schemas.In #564 @mkhraisha said he might like to add volumes on OilAndGasProduct, which seems like a reasonable approach but beyond the scope of this PR.