-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use generic names for the header and JS API #494
Conversation
This removes "IDP" from the HTTP header and JS API names so that they are more compatible with the is-logged-in API: https://github.com/privacycg/is-logged-in See also privacycg/is-logged-in#54 Open question: Should the JS API use the exact name in the current is-logged-in explainer (recordLoggedIn) or the more consistent name that this PR uses (recordSignedIn)?
@bvandersloot-mozilla FYI; this changes the explainer to use generic naming as discussed in the fedidcg yesterday. Spec PR update to come later. |
LGTM @bvandersloot-mozilla wdyt? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small grammar fixes
Yeah, this seems fine until we can get a verdict on Login Status API |
Thanks, I addressed the comments about the grammar. @samuelgoto , could you merge this PR? |
SHA: 273ccb0 Reason: push, by samuelgoto Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 273ccb0 Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This removes "IDP" from the HTTP header and JS API names so that they are more compatible with the is-logged-in API:
https://github.com/privacycg/is-logged-in
See also privacycg/is-logged-in#54
Open question:
Should the JS API use the exact name in the current is-logged-in explainer (recordLoggedIn) or the more consistent name that this PR uses (recordSignedIn)?