Use generic names for the header and JS API #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes "IDP" from the HTTP header and JS API names so that they are more compatible with the is-logged-in API: https://github.com/privacycg/is-logged-in See also privacycg/is-logged-in#54 Open question: Should the JS API use the exact name in the current is-logged-in explainer (recordLoggedIn) or the more consistent name that this PR uses (recordSignedIn)?
|
@bvandersloot-mozilla FYI; this changes the explainer to use generic naming as discussed in the fedidcg yesterday. Spec PR update to come later. |
|
LGTM @bvandersloot-mozilla wdyt? |
|
Yeah, this seems fine until we can get a verdict on Login Status API |
|
Thanks, I addressed the comments about the grammar. @samuelgoto , could you merge this PR? |
github-actions bot
added a commit
that referenced
this pull request
Aug 17, 2023
SHA: 273ccb0 Reason: push, by samuelgoto Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to mattdanielbrown/WebID
that referenced
this pull request
Aug 18, 2023
SHA: 273ccb0 Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes "IDP" from the HTTP header and JS API names so that they are more compatible with the is-logged-in API:
https://github.com/privacycg/is-logged-in
See also privacycg/is-logged-in#54
Open question:
Should the JS API use the exact name in the current is-logged-in explainer (recordLoggedIn) or the more consistent name that this PR uses (recordSignedIn)?