Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change confirm IDP login webdriver command to click dialog button #510

Merged
merged 5 commits into from
Nov 29, 2023
Merged

Change confirm IDP login webdriver command to click dialog button #510

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2a9654a
Change confirm IDP login webdriver command to click dialog button
tttzach Nov 7, 2023
109da9b
Change confirm IDP login webdriver command to click dialog button
tttzach Nov 7, 2023
6060406
Remove error API references
tttzach Nov 7, 2023
b1b58b5
Add commas
tttzach Nov 7, 2023
73d0360
Address npm's comments
tttzach Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 17 additions & 8 deletions spec/index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1981,9 +1981,9 @@ The [=remote end steps=] are:

1. Return [=success=] with data `null`.

## Confirm IDP login ## {#webdriver-confirmidplogin}
## Click dialog button ## {#webdriver-clickdialogbutton}

<figure id="table-webdriver-confirmidplogin" class="table">
<figure id="table-webdriver-clickdialogbutton" class="table">
<table class="data">
<thead>
<tr>
Expand All @@ -1994,20 +1994,29 @@ The [=remote end steps=] are:
<tbody>
<tr>
<td>POST</td>
<td>`/session/{session id}/fedcm/confirmidplogin`</td>
<td>`/session/{session id}/fedcm/clickdialogbutton`</td>
</tr>
</tbody>
</table>
</figure>

The [=remote end steps=] are:

1. If no FedCM dialog is currently open, or the dialog is not a [=confirm IDP
login dialog=] return a [=error|WebDriver error=] with [=error code=]
[=no such alert=].
1. If |parameters| is not a JSON [[ECMASCRIPT#sec-json-object|Object]], return a
[=error|WebDriver error=] with [=error code=] [=invalid argument=].

1. Let |dialogButton| be the result of [=getting a property=] named
`"dialogButton"` from |parameters|.

1. If |dialogButton| is not a string that is "`ConfirmIdpLoginContinue`", return
a [=error|WebDriver error=] with [=error code=] [=invalid argument=].

1. If no FedCM dialog is currently open or the dialog is not a [=confirm IDP
login dialog=], return a [=error|WebDriver error=] with [=error code=] [=no
such alert=].

1. Act as if the user had clicked the "continue" button in the dialog and
initiate the login flow.
1. Act as if the user had clicked the "continue" button in the [=confirm IDP
login dialog=] and initiate the login flow.

1. Return [=success=] with data `null`.

Expand Down
Loading