Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Initial algorithms / methods for putAll #343

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

inexorabletash
Copy link
Member

@inexorabletash inexorabletash commented Jun 30, 2020

Closes #69

The following tasks have been completed:

  • Confirmed there are no ReSpec/BikeShed errors or warnings.
  • Modified Web platform tests (link to pull request)

Implementation commitment:


Preview | Diff


Preview | Diff

@pwnall
Copy link

pwnall commented Jul 1, 2020

Thank you for working on this! The approach LGTM so far.

@inexorabletash inexorabletash changed the base branch from master to main July 23, 2020 16:18
@inexorabletash inexorabletash changed the title [WIP] Initial algorithms for putAll [WIP] Initial algorithms / methods for putAll Jul 23, 2020
@inexorabletash
Copy link
Member Author

Updated the PR to sketch out methods

f11de4f
git squash commit for putall.

4c8f697698a7ad567bdcc3075f34a76cbd03e723
git squash commit for putall.

5cc88a474a7ebae8fe3b505ffa4cad184988fbdd
git squash commit for putall.

008747487723e239b1badd7b2324cdf76ae95715
git squash commit for putall.

2bfcd08e6dcd6b68ab3135375c66f99ec45cfe34
git squash commit for putall.

5e447cac9eb4b2bd35a425e2ece7779a0ec6cb24
Initial algorithms for putAll

bb5627af9ec7f1e5819ae25ab7b6b9f7808c8fc4
Sketch out putAllXXX methods

e46dcd058e677f3bf7957938961670d54a65db81
rebased

69edb5b8a07b6cbce22d012fe0a9a9427a9f0553
rebase cleanup - still a weird idl ref error

5c8240291c541df290e3fe9feec9a1e073b845ee
disambiguate link

a201dcd56f706a91db57f589b6184d112411515a
bangbang

58bd52cf997d061aa8cbe344b0baea713a2ae860
fix TypeError link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Allow batch adding records (from an Array)
2 participants