Support space-separated list of AT settings #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outofambit
commented
Feb 6, 2025
| desiredResponse | ||
| ); | ||
| for (const setting of settingsArray) { | ||
| switch (setting.toLowerCase()) { |
There was a problem hiding this comment.
for the purposes of this control flow, we could ditch the lower casing and update the case statements but i was wary of doing so in case configuration elsewhere assumes that all lowercase is valid.
| @@ -90,30 +90,40 @@ export class DriverTestRunner { | |||
| /** | |||
| * Used for v2 tests to ensure proper settings. | |||
| * | |||
| * @param {string} settings - "browseMode" "focusMode" for NVDA, "pcCursor" "virtualCursor" | |||
| * for JAWS., "defaultMode" for others. | |||
There was a problem hiding this comment.
I remove the reference to JAWS because there is no JAWS functionality in this function
jugglinmike
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds support in the test harness for the changes in w3c/aria-at#1125. should be backwards compatible with current single setting approach.
if conflicting settings are in the list, whichever one is later in the list will win.
replaces #73