Fix monitor/ignore bot commands #1516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The monitor/ignore bot commands expected to receive as comment ID the same ID as the one returned by the `gh` CLI. That would have been way too easy! The comment ID in a workflow is an integer while the ID returned by the `gh` CLI is a string (probably an encoding of the number?). The code now computes the URL of the comment from the comment ID and uses that instead to find the comment in the list returned by `gh`. The update also fixes a bug in the regular expression used to extract the actual comment (extracted string included the "because" prefix). Closes #1496.
dontcallmedom
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The monitor/ignore bot commands expected to receive as comment ID the same ID as the one returned by the
ghCLI. That would have been way too easy! The comment ID in a workflow is an integer while the ID returned by theghCLI is a string (probably an encoding of the number?). The code now computes the URL of the comment from the comment ID and uses that instead to find the comment in the list returned bygh.The update also fixes a bug in the regular expression used to extract the actual comment (extracted string included the "because" prefix).
Closes #1496.