Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aria-labelledby AXAPI mapping to use AXTitle #230

Closed
wants to merge 2 commits into from

Conversation

rahimabdi
Copy link
Contributor

@rahimabdi rahimabdi commented May 5, 2024

Closes #215


Preview | Diff

@rahimabdi rahimabdi self-assigned this May 5, 2024
@rahimabdi rahimabdi requested a review from cookiecrook May 5, 2024 22:24
@jnurthen jnurthen requested a review from spectranaut May 9, 2024 17:09
@spectranaut
Copy link
Contributor

I'm pretty sure this is going to cause a change in chrome and firefox, is it not? Does this document reality in Safari?

Copy link
Contributor

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good - but from the issue, it looks like aria-label is updated to AXTitle as well, where you doing that in a separate PR? Seems to me like it could be done here as well.

@spectranaut
Copy link
Contributor

superseded by w3c/aria#2199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update AXAPI mapping for aria-label, aria-labelledby to use AXTitle
2 participants