[css-rythm-1] [editorial] remove redundant px
dimension from line-height-step
initial value
#11148
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
line-height-step
property in css-rythm-1 defines its initial value as0px
. AIUI - it being a zero value means thepx
is redundant.It seems to be more common to use
0
rather than0px
. In fact here are all the places that have an initial of0
:margin*
,padding*
)scroll-margin*
)baseline-shift
)shape-margin
,shape-padding
)text-indent
,line-padding
,hyphenate-limit-zone
)text-decoration-trim
)outline-offset
)border-*-radius
&border-radius
)And here are the places that have an initial of
0px
:line-height-step
- that's this one)border-spacing
- this initial value is0px 0px
)animation-delay
-0s
)transition-delay
,transition-duration
- both0s
)overflow-clip-margin*
- all0px
)background-position*
- all0%
)If this PR gets merged I'll follow up with one correcting
css-overflow
and perhaps the others 😉