[cssom-view-1] Minor corrections to scrolling algorithms #11701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This step makes more sense as step 11 (just after step 10 where `position` is declared) than step 10.9, and looks like a typo.
AtkinsSJ
added a commit
to AtkinsSJ/ladybird
that referenced
this pull request
Feb 12, 2025
Corresponds to w3c/csswg-drafts#11673 , with the addition of the fixes in w3c/csswg-drafts#11701
...from "determine the scroll-into-view position". This isn't used, and seems to be a leftover from before this algorithm was split out of "scroll a target into view".
AtkinsSJ
force-pushed
the
determine-scroll-into-view-position-step-number
branch
from
b50436a to
91fbe6d
Compare
kalenikaliaksandr
pushed a commit
to LadybirdBrowser/ladybird
that referenced
this pull request
Feb 12, 2025
Corresponds to w3c/csswg-drafts#11673 , with the addition of the fixes in w3c/csswg-drafts#11701
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 small corrections to the scrolling-related algorithms that came up while implementing them:
behaviorparameter to "determine the scroll-into-view position" is not used and seems to be a leftover from before it was split up.containeragainst inscrollIntoView(). I'm not 100% sure on this but out of the two options, "nearest" makes the most sense.