[cssom-view-1] Extend 'scroll into view' steps to Ranges #8254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smfr
approved these changes
Dec 22, 2022
bokand
added a commit
to WICG/scroll-to-text-fragment
that referenced
this pull request
Dec 22, 2022
This removes the monkey patches to CSSOM-View-1's 'scroll an element into view' steps as w3c/csswg-drafts#8254 made the necessary changes. They turned out to be much simpler, simply allowing using a Range in place of an Element since Range also implements `getBoundingClientRect`
jakearchibald
pushed a commit
to jakearchibald/csswg-drafts
that referenced
this pull request
Jan 16, 2023
Generalizes The scroll an element into view algorithm to work also work for a Range as well as an Element. This is trivial as the only use of Element is to call getBoundingClientRect which Range also defines. Additionally exports this algorithm for use in whatwg/html#8282. Nit: also fixes erroneous reference to a non-existent box variable where scrolling box was intended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[cssom-view-1] Extend 'scroll into view' steps to Ranges
Generalizes The
scroll an element into viewalgorithm to work also work for a Range as well as an Element. This is trivial as the only use of Element is to callgetBoundingClientRectwhich Range also defines.Additionally exports this algorithm for use in whatwg/html#8282.
Nit: also fixes erroneous reference to a non-existent
boxvariable wherescrolling boxwas intended.