Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add did:theseries method #550

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Add did:theseries method #550

merged 1 commit into from
Nov 10, 2024

Conversation

theseriesteam
Copy link
Contributor

DID Method Registration

As a DID method registrant, I have ensured that my DID method registration complies with the following statements:

@msporny
Copy link
Member

msporny commented Apr 1, 2024

@KDean-Dolphin
Copy link
Collaborator

My review got as far as the DID Document Definition. The document is non-conformant in at least the following:

  • version, created, and updated are metadata properties, not core properties (though in metadata it's versionId, not version)
  • publicKey is not a core property and appears to be a substitute for verificationMethod
  • id in the verification methods is a DID fragment, not a fully-formed DID URL as required
  • publicKeyHex is not a supported representation of a public key

@theseriesteam
Copy link
Contributor Author

I have modified the specification, could you please review again whether it meets the registration requirements ?
Thanks!

Copy link
Collaborator

@MizukiSonoko MizukiSonoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

I have read specification.
In my opinion, it have been better if method-specific section provides a specification like the Bacchus-Nauru format

@theseriesteam
Copy link
Contributor Author

theseriesteam commented Jun 3, 2024

Thank you for the review, I have modified the method-specific section.

msporny

This comment was marked as outdated.

Copy link
Member

@msporny msporny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Security and Privacy considerations section is lacking. Please see this specification for a good example of what a security and privacy considerations section should have:

https://did-dht.com/#security-and-privacy-considerations

@msporny
Copy link
Member

msporny commented Oct 14, 2024

@theseriesteam Please address the registration issues identified in this PR.

@theseriesteam
Copy link
Contributor Author

Copy link
Member

@msporny msporny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meets minimum requirements for registration.

@msporny msporny merged commit e662003 into w3c:main Nov 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants