-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add did:theseries method #550
Conversation
New DID Method review volunteers, please review this DID Method. /cc @apuchitnis @stenreijers @gatemezing @esaung @michallis @richardwinputra @adam-burns @Steffytan @MizukiSonoko @rajivrajani @genaris @harleyjackthomas @ajile-in @KDean-Dolphin |
My review got as far as the DID Document Definition. The document is non-conformant in at least the following:
|
I have modified the specification, could you please review again whether it meets the registration requirements ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
I have read specification.
In my opinion, it have been better if method-specific section provides a specification like the Bacchus-Nauru format
Thank you for the review, I have modified the method-specific section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Security and Privacy considerations section is lacking. Please see this specification for a good example of what a security and privacy considerations section should have:
@theseriesteam Please address the registration issues identified in this PR. |
Sorry for the late reply, I've updated the document. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meets minimum requirements for registration.
DID Method Registration
As a DID method registrant, I have ensured that my DID method registration complies with the following statements:
contactEmail
address [OPTIONAL].verifiableDataRegistry
entry [OPTIONAL].