Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create hrdkorea.json #553

Closed
wants to merge 4 commits into from
Closed

Create hrdkorea.json #553

wants to merge 4 commits into from

Conversation

HRDKOR
Copy link

@HRDKOR HRDKOR commented Mar 24, 2024

Instructions for Pull Requests

Please read these instructions thoroughly in order to ensure that your pull request is processed in a timely manner. This document contains detailed instructions for registering a DID Method. If your pull request concerns some other change to the repository, you may delete all of the text in this text box and write up a more relevant description.

There is a DID Method Registration form below that MUST be included in a DID Method Registration Request. The form includes check boxes that you are expected to fill out when you submit your request.

Once you submit your request, your pull request will be reviewed by the registry editors. Changes regarding the required criteria may be requested. If there are no objections or changes requested, your DID method will be registered after a minimum of 7 days and a maximum of 30 days.

DID Method Registration Process

In order to register a new DID method, you must add a JSON file to the ./methods directory.

Here is an example registration entry:

{
  // These fields are required
  "name": "example",
  "status": "registered",
  "specification": "https://w3c-ccg.github.io/did-spec/",
  // These fields are optional
  "contactName": "W3C Credentials Community Group",
  "contactEmail": "",
  "contactWebsite": "",
  "verifiableDataRegistry": "DID Specification"
}

Your Pull Request will be automatically validated, please ensure that all of the automated tests pass (no errors reported) or your submission will not be reviewed. Common reasons for failed validation includes invalidly formatted JSON files and missing mandatory fields.

----- DID METHOD REGISTRATION FORM: DELETE EVERYTHING ABOVE THIS LINE ------

DID Method Registration

As a DID method registrant, I have ensured that my DID method registration complies with the following statements:

@HRDKOR HRDKOR requested review from msporny and mprorock as code owners March 24, 2024 02:37
@TallTed TallTed mentioned this pull request Mar 26, 2024
7 tasks
Copy link
Member

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to address HRDKOR/hrdkorea-did#1

// These fields are optional
"contactName": "HRDKorea",
"contactEmail": "",
"contactWebsite": "mq.q-net.or.kr",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Domain does not resolve

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We fixed it. thank you.

@msporny
Copy link
Member

msporny commented Apr 1, 2024

@KDean-Dolphin
Copy link
Collaborator

  • JSON includes //-delineated comments, which are not allowed
  • specification refers to GitHub.com, which in turn refers to GitHub.io
  • contactEmail is blank and should be removed
  • contactWebsite does not resolve

Copy link
Member

@msporny msporny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The JSON markup is invalid; JSON does not support comments.

The Privacy and Security Considerations section does not meet minimum requirements (write at least a few paragraphs). Please see this specification for a good example of those sections: https://did-dht.com/#security-and-privacy-considerations

@msporny
Copy link
Member

msporny commented Jul 20, 2024

Closing, duplicate of #554

@msporny msporny closed this Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants