Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Geometry-1] TYPO: transposed DOMPointReadOnly and DOMPoint... #291

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fuchsia
Copy link

@fuchsia fuchsia commented Jun 1, 2018

Typo: transposed DOMPointReadOnly and DOMPoint so the text matches the IDL. I think that's what was intended. (As with so much of this spec, the intent is opaque.)

...so the text matches the IDL.
Copy link
Contributor

@dirkschulze dirkschulze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence actually seems to be correct to me. DOMPoint inherits from DOMPointReadOnly.

@tabatkins
Copy link
Member

Ah, I suppose what's unclear here is that the use of "inheriting interface" can be read as the opposite relationship ("the interface it's inheriting from") - "inherited interface" is the more usual form of the term.

@plehegar
Copy link
Member

plehegar commented Jun 6, 2018

Marked as non substantive for IPR from ash-nazg.

@fuchsia
Copy link
Author

fuchsia commented Jun 8, 2018

I think my brain was trying to parse it as: "{{DOMPoint}}, as well as the inheriting the interface {{DOMPointReadOnly}}, must be able to access and set the value of these variables." But, on a slow read, after someone's pointed out what was intended and the import of the following paragraph has sunk in, the original makes sense.

At this point, I just want to close the request to save some embarrassment. But, it is a confusing chunk. So, quickly sketching, maybe that sentence should be folded into the next paragraph, and the distracting ref to DOMPoint dropped, so it reads:

The value of these internal member variables may be set, as well as read. And an interface exposing a {{DOMPointReadOnly}} object as an attribute or returning a {{DOMPointReadOnly}} object from a function may be able to modify internal member variable values. Such an interface must specify this ability explicitly in prose.

@svgeesus
Copy link
Contributor

So, is this "close, no edits needed"? Or are we waiting for edits for this small PR?

@dirkschulze
Copy link
Contributor

@svgeesus I think the outcome is that the spec is correct but the spec text could be simplified (non-normative change).

Base automatically changed from master to main February 2, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants