-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Geometry-1] TYPO: transposed DOMPointReadOnly and DOMPoint... #291
base: main
Are you sure you want to change the base?
Conversation
...so the text matches the IDL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence actually seems to be correct to me. DOMPoint inherits from DOMPointReadOnly.
Ah, I suppose what's unclear here is that the use of "inheriting interface" can be read as the opposite relationship ("the interface it's inheriting from") - "inherited interface" is the more usual form of the term. |
Marked as non substantive for IPR from ash-nazg. |
I think my brain was trying to parse it as: "{{DOMPoint}}, as well as At this point, I just want to close the request to save some embarrassment. But, it is a confusing chunk. So, quickly sketching, maybe that sentence should be folded into the next paragraph, and the distracting ref to DOMPoint dropped, so it reads:
|
So, is this "close, no edits needed"? Or are we waiting for edits for this small PR? |
@svgeesus I think the outcome is that the spec is correct but the spec text could be simplified (non-normative change). |
Typo: transposed DOMPointReadOnly and DOMPoint so the text matches the IDL. I think that's what was intended. (As with so much of this spec, the intent is opaque.)