remove old demjson python package #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
I'm ok to remove it to unblock the ci, but jsonlint served a purpose the two others don't - detecting duplicate keys. Could you file an issue to track this need? |
dontcallmedom
approved these changes
Dec 21, 2022
|
Looking around, but I could not find easy way in python (some modules seems there for node.js via npm...) for detecting dup over nested dictionary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #248 GHAction error, demjson package installation seems failed.
https://github.com/w3c/github-notify-ml-config/actions/runs/3742513254/jobs/6353548440
Since
python -mjson.tool, both of which are validation in strict mode, so dup as functionalityI'd propose to remove this tool and validation line, with keeping validation by json package, as this PR.
/cc @anssiko