-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Managed Media Source Extensions API #329
Conversation
… once per operation, not whenever the buffer changes.
Co-authored-by: Marcos Cáceres <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Defer to editors for approval, but largely looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of editorial comments, but the general concept looks good to me still.
…e per Paul's suggestion
Co-authored-by: Jean-Yves Avenard <[email protected]>
Co-authored-by: Jean-Yves Avenard <[email protected]>
Co-authored-by: Jean-Yves Avenard <[email protected]>
Ok, I think we have addressed all outstanding feedback. Thanks again @wolenetz for the detailed review. Can you check you are satisfied with the responses and give a tick ✅ if all looks good. Please feel free to make any further suggesting directly in the pull request. If we don't hear back in 2 weeks, we will assume everything is good and merge. We can always follow up with issues or more pull requests after we merge. In the meantime, we will make sure to check the state of the WPTests and make sure we have covered as much we can for the purpose of interop. |
I have just one question: does ManagedMediaSource work with MediaSourceHandle, to enable use of ManagedMediaSource in a Worker, and are there test cases for this? |
There's nothing specific about ManagedMediaSource when it comes to working in a Worker. All the apply for MediaSource should apply. webkit doesn't support that feature at present. |
SHA: 2cb6b9a Reason: push, by jyavenard Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
As proposed in #320.
Preview | Diff