Add contributors, and sort alphabetically #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolenetz
suggested changes
Nov 9, 2023
|
As a followup, can we just move this into the spec itself? I'm trying to remove the old JS file because it conflicts with ReSpec's processing. Also, ReSpec can include actual contributions based on git history. That can more accurately reflect contribution and doesn't need manual maintenance (except in the rare case of a "special thanks"). |
|
Actually, I just went and did it. "gh-contributors" listed mostly the same people, so didn't add much value. |
|
Thanks @marcoscaceres, that's much improved. |
github-actions bot
added a commit
that referenced
this pull request
Nov 14, 2023
SHA: 6da1bef Reason: push, by marcoscaceres Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #335
Preview | Diff