Direct Connection Permission #196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
I'm happy with this PR. |
alvestrand
reviewed
Nov 14, 2019
| </h3> | ||
| <p> | ||
| The <dfn for="PermissionName" enum-value>"direct-connection"</dfn> | ||
| permission upgrades to a less strict IP handling mode of |
There was a problem hiding this comment.
Can consider saying "mode 1" here, rather than "a less strict IP handling mode".
|
Closing... these are now defined inside specifications themselves. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new permission called
direct-connectionwhich specifies how the IP handling mode of a WebRTC peer-to-peer connection is being upgraded.A couple of background notes: The mechanism triggering the upgrade of the IP handling mode, piggybacked on
getUserMedia, already exists in most browsers but it is not being reflected in the API. This change now allows to leverage the permission by other mechanisms and clarifies thatgetUserMediamay implicitly grant it.More details on the rationale are being described in the Direct Connection PR towards the WebRTC WG.
/cc @jan-ivar @alvestrand
Preview | Diff