Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editorial] Making the diagram dark-mode safe #210

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

iherman
Copy link
Member

@iherman iherman commented Oct 12, 2023

This changes the vocab diagram to be dark-mode safe, by essentially using only a few colors for the connector lines. The content of the diagram has not changed.

Furthermore, just as what was done in w3c/vc-data-model#1296 for the VCDM spec, the original drawio source of the diagram has been added to the repository to make make updates and changes better tracable. The README file has been updated accordingly.

@iherman iherman self-assigned this Oct 12, 2023
@iherman iherman added the CR1 This item was processed during the first Candidate Recommendation phase. label Oct 12, 2023
Copy link
Contributor

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@msporny
Copy link
Member

msporny commented Oct 13, 2023

Purely editorial, multiple reviews, merging.

@msporny msporny merged commit 38b44ff into main Oct 13, 2023
@msporny msporny deleted the iherman-bw_diagram-source-on-github branch October 13, 2023 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR1 This item was processed during the first Candidate Recommendation phase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants