Clarifying language from #270 #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wind4Greg
approved these changes
Jul 1, 2024
dlongley
approved these changes
Jul 1, 2024
index.html
Outdated
| JSON, YAML, or CBOR, will need to keep this in mind if they merge data from one | ||
| document with data from another, such as when an `id` value string is the same | ||
| in both documents. It is important to not merge objects that seem to have similar | ||
| properties, but which properties do not contain an `id` property or use a global |
There was a problem hiding this comment.
Had a hard time parsing this. Maybe this?
Suggested change
| properties, but which properties do not contain an `id` property or use a global | |
| properties, but do not contain an `id` property or use a global |
There was a problem hiding this comment.
Yeah... I think more needs to be tweaked than those words. See below.
TallTed
commented
Jul 1, 2024
msporny
approved these changes
Jul 1, 2024
Co-authored-by: Ted Thibodeau Jr <[email protected]>
|
Purely editorial, merging. |
msporny
added
CR1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may need further massaging. I was a bit too slow in reviewing #270.
Preview | Diff