Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update error codes in yaml file to match those in spec (html). #283

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Update error codes in yaml file to match those in spec (html). #283

merged 1 commit into from
Jul 15, 2024

Conversation

Wind4Greg
Copy link
Collaborator

This is a follow on PR to PR #274 which addressed issues w3c/vc-di-eddsa#82, w3c/vc-di-ecdsa#63, and w3c/vc-di-bbs#168.

This PR updates the vocabulary.yml files error codes to match those in the spec (index.html).

@Wind4Greg Wind4Greg requested a review from msporny as a code owner July 8, 2024 17:09
@Wind4Greg Wind4Greg requested review from iherman, TallTed, msporny and dlongley and removed request for msporny July 8, 2024 17:09
iherman
iherman approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@iherman iherman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to the PR , but issue #284 must be handled first, otherwise the vocabulary will include dangling links.

(That issue has been handled.)

aljones15
aljones15 approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@aljones15 aljones15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but not very in touch with these changes.

@msporny msporny added CR1 This item was processed during the first Candidate Recommendation phase. editorial This issue or PR constitutes an editorial change. labels Jul 15, 2024
@msporny
Copy link
Member

msporny commented Jul 15, 2024

Editorial, multiple reviews, no changes requested, no objections, merging.

@msporny msporny merged commit 1b42034 into w3c:main Jul 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TallTed TallTed TallTed approved these changes

@iherman iherman iherman approved these changes

@aljones15 aljones15 aljones15 approved these changes

@dlongley dlongley dlongley approved these changes

@msporny msporny msporny approved these changes

Assignees
No one assigned
Labels
CR1 This item was processed during the first Candidate Recommendation phase. editorial This issue or PR constitutes an editorial change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Wind4Greg @msporny @dlongley @aljones15 @iherman @TallTed