-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define ControllerDocument class. #320
Conversation
The PR is incomplete, because the diagram must be updated as well and. It is also a question whether the domain of the "controller" property shouldn't be specified as a union (ie, logical 'or') for a controller document class and the verification method class. @msporny I think I should take it over, because I have more practice in creating/changing the diagram. I will clone your branch and take it from there if you are fine with it. |
I don't think we should limit the domain just yet... controller might make sense in many more use cases.
Yes, please take it over @iherman ... and thank you! :) |
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The redundant department of redundancy department thanks you for your support.
Co-authored-by: Ted Thibodeau Jr <[email protected]>
2d732d7
to
de78868
Compare
Editorial, multiple reviews, changes requested and made, no objections, merging. |
This PR is an attempt to address issue #322 by defining a ControllerDocument class.
/cc @filip26