Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define ControllerDocument class. #320

Merged
merged 3 commits into from
Nov 23, 2024
Merged

Define ControllerDocument class. #320

merged 3 commits into from
Nov 23, 2024

Conversation

msporny
Copy link
Member

@msporny msporny commented Nov 16, 2024

This PR is an attempt to address issue #322 by defining a ControllerDocument class.

/cc @filip26

@iherman
Copy link
Member

iherman commented Nov 17, 2024

The PR is incomplete, because the diagram must be updated as well and. It is also a question whether the domain of the "controller" property shouldn't be specified as a union (ie, logical 'or') for a controller document class and the verification method class.

@msporny I think I should take it over, because I have more practice in creating/changing the diagram. I will clone your branch and take it from there if you are fine with it.

@msporny
Copy link
Member Author

msporny commented Nov 17, 2024

It is also a question whether the domain of the "controller" property shouldn't be specified as a union (ie, logical 'or') for a controller document class and the verification method class.

I don't think we should limit the domain just yet... controller might make sense in many more use cases.

@msporny I think I should take it over, because I have more practice in creating/changing the diagram. I will clone your branch and take it from there if you are fine with it.

Yes, please take it over @iherman ... and thank you! :)

@iherman
Copy link
Member

iherman commented Nov 19, 2024

It is also a question whether the domain of the "controller" property shouldn't be specified as a union (ie, logical 'or') for a controller document class and the verification method class.

I don't think we should limit the domain just yet... controller might make sense in many more use cases.

@msporny I think I should take it over, because I have more practice in creating/changing the diagram. I will clone your branch and take it from there if you are fine with it.

Yes, please take it over @iherman ... and thank you! :)

Done.

Copy link
Member

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The redundant department of redundancy department thanks you for your support.

vocab/security/template.html Outdated Show resolved Hide resolved
vocab/security/template.html Outdated Show resolved Hide resolved
@msporny
Copy link
Member Author

msporny commented Nov 23, 2024

Editorial, multiple reviews, changes requested and made, no objections, merging.

@msporny msporny merged commit 03720bf into main Nov 23, 2024
2 checks passed
@msporny msporny deleted the msporny-define-cd branch November 23, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants