Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin node 20.8 #39

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Unpin node 20.8 #39

merged 2 commits into from
Nov 28, 2023

Conversation

aljones15
Copy link
Contributor

@aljones15 aljones15 commented Nov 28, 2023 •
edited
Loading

  1. unpins test runner so it will run on the latest version of node 20
  2. updates engines.node to >= 18 to match other test projects (semver.satisifies likes this pattern)

@aljones15 aljones15 self-assigned this Nov 28, 2023
@aljones15 aljones15 merged commit b340513 into main Nov 28, 2023
2 checks passed
@aljones15 aljones15 deleted the unpin-node-20.8 branch November 28, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JSAssassin JSAssassin JSAssassin approved these changes

@BigBlueHat BigBlueHat BigBlueHat approved these changes

@msporny msporny Awaiting requested review from msporny

Assignees

@aljones15 aljones15

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aljones15 @BigBlueHat @JSAssassin