Vocabulary fixes

[OR13]

No description provided.

[awoie]

lgtm

[iherman]

The issue was discussed in a meeting on 2023-08-15

• no resolutions were taken

View the transcript

1.8. Vocabulary fixes (pr vc-data-model#1241)

See github pull request vc-data-model#1241.

Brent Zundel: next PR is 1241 vocab fixes. seems straightforward. Orie do you want to speak to it?

See github issue vc-data-model#1240.

Orie Steele: copy-paste bug in the render method. question I had asked to Ivan on the value of the label property. related to issue linked (1240). slightly improves our vocabulary.

[iherman]

I approved the PR, but it seems to be incomplete.

• If we introduce the cred:RenderMethod class as a range, then this class should be added to the vocabulary (it is currently not there). Probably as a 'reserved' class, just as the property itself
• The vocabulary diagram is also incomplete: at this moment, nothing is indicated as a range for the property.

@OR13 what is your preference? I can take over the PR by adding these to the branch, I can issue a PR against this branch, or we would merge this PR and I will then step in with a new PR with these changes. Whatever you prefer.

Making a PR on top of this one turned out to be problematic, because the underlying main branch has changed too much with the addition of the diagram. It would have led to merge conflicts.

@OR13, I have created a new PR (#1253) which includes your proposed changes, plus the missing features mentioned above. Please check whether that is fine, and then we can close this PR without merge in favor of #1253.

@msporny @dlongley @longpd @decentralgabe @brentzundel @awoie @seabass-labrax