Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed references to controller documents to cid #110

Merged
merged 3 commits into from
Feb 17, 2025
Merged

Changed references to controller documents to cid #110

merged 3 commits into from
Feb 17, 2025

Conversation

iherman
Copy link
Member

@iherman iherman commented Feb 4, 2025 •
edited by pr-preview bot
Loading

Now that cid is there...

Preview | Diff

@iherman iherman added the editorial This item is editorial in nature. label Feb 4, 2025
dlongley
dlongley approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Not sure if there will be any conflicts with #109 around fixing references.

@msporny msporny force-pushed the change-the-controller-document-references branch from 3bec755 to fd3b7d7 Compare February 17, 2025 22:05
@msporny
Copy link
Member

msporny commented Feb 17, 2025

Editorial, multiple reviews, changes requested and made, no objections, merging.

@msporny msporny merged commit 63e3e50 into main Feb 17, 2025
2 checks passed
@msporny msporny deleted the change-the-controller-document-references branch February 17, 2025 22:07
@msporny msporny added the CR2 This item was processed during the second Candidate Recommendation Phase label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msporny msporny msporny approved these changes

@dlongley dlongley dlongley approved these changes

@Wind4Greg Wind4Greg Wind4Greg approved these changes

@dmitrizagidulin dmitrizagidulin Awaiting requested review from dmitrizagidulin dmitrizagidulin is a code owner

@seabass-labrax seabass-labrax Awaiting requested review from seabass-labrax

Assignees
No one assigned
Labels
CR2 This item was processed during the second Candidate Recommendation Phase editorial This item is editorial in nature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iherman @msporny @dlongley @Wind4Greg