-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to normative statements #143
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions reinforcing the definition of what an SD-JWT is.
Selectively Disclosable JWT (SD-JWT):
A composite structure, consisting of an Issuer-signed JWT (JWS, [RFC7515]), Disclosures, and optionally a Key Binding JWT that supports selective disclosure as defined in this document. It can contain both regular claims and digests of selectively-disclosable claims.
Importantly, an SD-JWT is NOT a JWT.
why changing MUST to SHOULD allows more explicit typing..? if there is one media type that is to be used, why not mandate it..? what am I missing |
@Sakurann at the last IETF, I asked a lot of people about this... There was some concern over not allowing specific VCs to use the more specific typing, similar to sec+jwt using it... This allows for that to happen with W3C VCs, so perhaps some token processors might do foo+sd-jwt instead of vc+ld+json+sd-jwt... It also reduces the risk of further issues with multiple suffixes in case there are issues that arise with it in the future. |
The issue was discussed in a meeting on 2023-08-30
View the transcript1.1. Changes to normative statements (pr vc-jose-cose#143)See github pull request vc-jose-cose#143. Brent Zundel: looking to transition to CR no later than end of September. Michael Prorock: one PR ready to merge (vc-jose-cose). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add rationale. Say that it's a SHOULD so that more specific media types can be used.
Including the reason for the SHOULD would be helpful. Might also consider " |
The issue was discussed in a meeting on 2023-09-05
View the transcript4.1. Changes to normative statements (pr vc-jose-cose#143)See github pull request vc-jose-cose#143. Orie Steele: lot of discussions about media types at last IETF.
Michael Jones: rationale should be included to say this media type should be used unless a profile specifies a more specific media type. |
@selfissued @TallTed added guidance based on your review in : 6a821e1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Language tweaks, to hopefully clarify somewhat...
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@TallTed thanks for your suggestions, both are applied. @selfissued can you please re-review. |
The most specific media type (or subtype) available SHOULD be used, instead of | ||
more generic media types (or supertypes). For example, rather than the general | ||
<code>application/sd-jwt</code>, <code>application/vc+ld+json+sd-jwt</code> | ||
ought to be used, unless there is a more specific media type that would even |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ought to be used, unless there is a more specific media type that would even | |
should to be used, unless there is a more specific media type that would even |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ought to
was meant to avoid potential confusion of should
with SHOULD
.
If should
is now to be kept, should to be
should be changed to should be
or perhaps SHOULD be
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to avoid the normative language
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the rationale.
Co-authored-by: Kristina <[email protected]>
Aligns with #141
This PR, changes MUST to SHOULD to allow for more specific typing via media types.
This PR also recommends securing with JOSE be done with sd-jwt
Preview | Diff