Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify relationship between "iss" and "issuer" #146

Merged
merged 4 commits into from
Sep 12, 2023
Merged

Clarify relationship between "iss" and "issuer" #146

merged 4 commits into from
Sep 12, 2023

Conversation

Sakurann
Copy link
Contributor

@Sakurann Sakurann commented Sep 7, 2023

as agreed in Issue #22


Preview | Diff

index.html Outdated Show resolved Hide resolved
Copy link
Contributor

@OR13 OR13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to take without the suggestion, but I think its confusing to say iss MUST match a required attribute, when iss is optional.

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
Copy link
Member

@brentzundel brentzundel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with Sakurann's changes

@Sakurann Sakurann merged commit cbfba24 into main Sep 12, 2023
1 check passed
@decentralgabe decentralgabe deleted the iss-issuer branch February 26, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants